linux-kernel - Re: [PATCHv10 2.6.35-rc6-tip 11/14] perf: perf interface for uprobes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 02 Aug 2010 10:51:01 +0900
From:	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>
To:	Arnaldo Carvalho de Melo <acme@...radead.org>
Cc:	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...e.hu>,
	Steven Rostedt <rostedt@...dmis.org>,
	Randy Dunlap <rdunlap@...otime.net>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Christoph Hellwig <hch@...radead.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Mark Wielaard <mjw@...hat.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Naren A Devaiah <naren.devaiah@...ibm.com>,
	Jim Keniston <jkenisto@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	"Frank Ch. Eigler" <fche@...hat.com>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	2nddept-manager@....hitachi.co.jp
Subject: Re: [PATCHv10 2.6.35-rc6-tip 11/14]  perf: perf interface for uprobes

Arnaldo Carvalho de Melo wrote:
> Em Sat, Jul 31, 2010 at 08:27:48AM +0530, Srikar Dronamraju escreveu:
>>>> @@ -1598,15 +1812,19 @@ struct __event_package {
>>>>  int add_perf_probe_events(struct perf_probe_event *pevs, int npevs,
>>>>  			  bool force_add, int max_tevs)
>>>>  {
>>>> -	int i, j, ret;
>>>> +	int i, j, ret = 0;
>>>>  	struct __event_package *pkgs;
>>>>  
>>>>  	pkgs = zalloc(sizeof(struct __event_package) * npevs);
>>>>  	if (pkgs == NULL)
>>>>  		return -ENOMEM;
>>>>  
>>>> -	/* Init vmlinux path */
>>>> -	ret = init_vmlinux();
>>>> +	if (!pevs->upid)
>>>> +		/* Init vmlinux path */
>>>> +		ret = init_vmlinux();
>>>> +	else
>>>> +		ret = init_perf_uprobes();
>>>> +
>>>>  	if (ret < 0)
>>> pkgs leaks here.
>> Right, but I dont think this leak was introduced by my patch(s). I
>> guess its better fixed by a different patch. 
> 
> Sorry, will fix that then on a separate patch.

Yes, sorry, that was introduced by me...

Thanks for pointing it out.

-- 
Masami HIRAMATSU
2nd Research Dept.
Hitachi, Ltd., Systems Development Laboratory
E-mail: masami.hiramatsu.pt@...achi.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/