linux-kernel - Re: [PATCH] kconfig: fix make oldconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Aug 2010 23:02:03 -0700
From:	"Justin P. Mattock" <justinmattock@...il.com>
To:	Sam Ravnborg <sam@...nborg.org>
CC:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Michal Marek <mmarek@...e.cz>, JBeulich@...ell.com,
	aris@...hat.com, catalin.marinas@....com, jacmet@...site.dk,
	lizf@...fujitsu.com, ulfalizer.lkml@...il.com,
	zippel@...ux-m68k.org, linux-kbuild@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kconfig: fix make oldconfig

> [PATCH] kconfig: fix make oldconfig
>
> Linus wrote:
>   This seems to make "make oldconfig" a _lot_ more verbose than it
>   used to be. In a very annoying way.
>
>   I just did a quick git bisect. It's introduced by commit 4062f1a4c030
>   ("kconfig: use long options in conf") by Sam Ravnborg. Apparently that
>   thing is totally buggy, and doesn't just change the option names, but
>   actively breaks them.
>
> The old behaviour (from years ago) were reintroduced by accident.
> Fix this so we are back to the version that are silent
> if there is nothing to ask about.
>
> Reported-by: Linus Torvalds<torvalds@...ux-foundation.org>
> Signed-off-by: Sam Ravnborg<sam@...nborg.org>
> ---
>
> Sorry for this regression. Dunno how I missed it.
> I guess I only tested "silentoldconfig".
>
> Following patch seems obviously correct but as I am on the way
> out of the door I could not do much testing.
>
> 	Sam
>
> diff --git a/scripts/kconfig/conf.c b/scripts/kconfig/conf.c
> index 010600e..274f271 100644
> --- a/scripts/kconfig/conf.c
> +++ b/scripts/kconfig/conf.c
> @@ -599,12 +599,12 @@ int main(int ac, char **av)
>   		break;
>   	case savedefconfig:
>   		break;
> -	case oldconfig:
>   	case oldaskconfig:
>   		rootEntry =&rootmenu;
>   		conf(&rootmenu);
>   		input_mode = silentoldconfig;
>   		/* fall through */
> +	case oldconfig:
>   	case listnewconfig:
>   	case oldnoconfig:
>   	case silentoldconfig:
>

Id like to be more useful with really hitting this, seems I was for a 
few moments, then something in there tripped and caused oldconfig to 
behave.. anyways only real evidence I have of hitting this is an fpaste 
of my shell output http://fpaste.org/LFew/

Anyways applied your patch below, make oldconfig worked as is no:

  make oldconfig
scripts/kconfig/conf -o arch/x86/Kconfig
#
# configuration written to .config
#

that I was hitting for some reason or another then all of a sudden 
disappeared.

Justin P. Mattock
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/