linux-kernel - Re: [PATCH 05/10] perf hists: Fixup addr snprintf width on 32 bit arches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 6 Aug 2010 11:29:45 -0300
From:	Arnaldo Carvalho de Melo <acme@...radead.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Frederic Weisbecker <fweisbec@...il.com>,
	Mike Galbraith <efault@....de>,
	Peter Zijlstra <peterz@...radead.org>,
	Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 05/10] perf hists: Fixup addr snprintf width on 32 bit
	arches

Em Thu, Aug 05, 2010 at 06:58:07PM -0700, Joe Perches escreveu:
> On Thu, 2010-08-05 at 22:46 -0300, Arnaldo Carvalho de Melo wrote:
> > From: Arnaldo Carvalho de Melo <acme@...hat.com>
> > By using BITS_PER_LONG/4 as the width specifier.
> []
> > diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c
> > index 1c61a4f..b62a553 100644
> > --- a/tools/perf/util/sort.c
> > +++ b/tools/perf/util/sort.c
> []
> > -		ret += repsep_snprintf(bf, size, "%#018llx %c ", self->ip, o);
> > +		ret += repsep_snprintf(bf, size, "%*Lx %c ",
> > +				       BITS_PER_LONG / 4, self->ip, o);
> []
> > -		ret += repsep_snprintf(bf + ret, size - ret, "%#016llx", self->ip);
> > +		ret += repsep_snprintf(bf + ret, size - ret, "%*Lx",
> > +				       BITS_PER_LONG / 4, self->ip);
> 
> This drops leading 0's.

Is this a problem? This removes clutter from the output, right?

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/