linux-kernel - Re: [Stable-review] [26/34] CIFS: Fix compile error with __init in cifs_init_dns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 07 Aug 2010 13:38:53 +1000
From:	Michael Neuling <mikey@...ling.org>
To:	Greg KH <gregkh@...e.de>
cc:	Ben Hutchings <ben@...adent.org.uk>, linux-kernel@...r.kernel.org,
	stable@...nel.org, David Howells <dhowells@...hat.com>,
	linux-cifs@...r.kernel.org, Jeff Layton <jlayton@...hat.com>,
	akpm@...ux-foundation.org, torvalds@...ux-foundation.org,
	stable-review@...nel.org, alan@...rguk.ukuu.org.uk
Subject: Re: [Stable-review] [26/34] CIFS: Fix compile error with __init in cifs_init_dns_resolver() definition



In message <20100806210619.GA5863@...e.de> you wrote:
> On Fri, Aug 06, 2010 at 09:53:17PM +0100, Ben Hutchings wrote:
> > On Fri, 2010-08-06 at 11:57 -0700, Greg KH wrote:
> > > 2.6.32-stable review patch.  If anyone has any objections, please let us 
know.
> > > 
> > > ------------------
> > >  [stable] [PATCH 2.6.32/stable] CIFS: Fix compile error with __init in ci
fs_init_dns_resolver() definition
> > > 
> > > From: Michael Neuling <mikey@...ling.org>
> > > 
> > > An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this erro
r
> > > 
> > > fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attr
ibute__' before 'cifs_init_dns_resolver'
> > > 
> > > This adds the correct header file to fix this.
> > [...]
> > 
> > Why <linux/module.h> and not <linux/init.h>?
> 
> Heh, it works :)
> 
> Michael?

It's what David Howells wanted.....

http://linux.derkeiler.com/Mailing-Lists/Kernel/2010-08/msg01316.html
(below as well)


> An allmodconfig compile on ppc64 with 2.6.32.17 currently gives this error
> 
> fs/cifs/dns_resolve.h:27: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'cifs_init_dns_resolver'
> 
> This removes the __init from cifs_init_dns_resolver()

That's not really a good idea as the assembler may choose different pieces of
assembly to do variable references and jumps, depending on the section
information.

A better fix is to add:

	#include <linux/module.h>

to the header file.

David

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/