linux-kernel - Re: [PATCH 1/4] mfd: max8998 - fix incorrect kfree(i2c) in i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 9 Aug 2010 11:15:31 +0200
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Liam Girdwood <lrg@...mlogic.co.uk>
Subject: Re: [PATCH 1/4] mfd: max8998 - fix incorrect kfree(i2c) in
 i2c_driver probe callback handler

Hi Axel,

On Mon, Aug 09, 2010 at 02:48:16PM +0800, Axel Lin wrote:
> The i2c_client received in probe() should not be kfree()'d.
This should go through Liam's tree, I'm  CC'ing him to this thread.

Cheers,
Samuel.


> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/mfd/max8998.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mfd/max8998.c b/drivers/mfd/max8998.c
> index 0d68de2..73e6f5c 100644
> --- a/drivers/mfd/max8998.c
> +++ b/drivers/mfd/max8998.c
> @@ -89,10 +89,8 @@ static int max8998_i2c_probe(struct i2c_client *i2c,
>  	int ret = 0;
>  
>  	max8998 = kzalloc(sizeof(struct max8998_dev), GFP_KERNEL);
> -	if (max8998 == NULL) {
> -		kfree(i2c);
> +	if (max8998 == NULL)
>  		return -ENOMEM;
> -	}
>  
>  	i2c_set_clientdata(i2c, max8998);
>  	max8998->dev = &i2c->dev;
> -- 
> 1.5.4.3
> 
> 
> 

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/