linux-kernel - Re: [PATCHv6 1/7] USB: gadget: storage_common: fixed warning building mass storage function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 9 Aug 2010 13:52:38 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Michal Nazarewicz <m.nazarewicz@...sung.com>
Cc:	Greg KH <greg@...ah.com>, David Brownell <david-b@...bell.net>,
	USB <linux-usb@...r.kernel.org>,
	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv6 1/7] USB: gadget: storage_common: fixed warning building 
	mass storage function

On Thu, Aug 5, 2010 at 1:27 PM, Michal Nazarewicz
<m.nazarewicz@...sung.com> wrote:
> The "nofua" attribute is used in the File-Storage Gadget but the
> functions handling it are defined in storage_common.c (which may be
> not a bad thing if anyone will want to port tho "nofua" attribute to
> mass storage function) which causes the following warnings:
>
> drivers/usb/gadget/storage_common.c:718: \
>  warning: ‘fsg_show_nofua’ defined but not used
> drivers/usb/gadget/storage_common.c:782: \
>  warning: ‘fsg_store_nofua’ defined but not used
>
> Adding __maybe_unused fixes this issue.
>
> Signed-off-by: Michal Nazarewicz <m.nazarewicz@...sung.com>
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> ---
>  drivers/usb/gadget/storage_common.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/gadget/storage_common.c b/drivers/usb/gadget/storage_common.c
> index 484acfb..3379cc3 100644
> --- a/drivers/usb/gadget/storage_common.c
> +++ b/drivers/usb/gadget/storage_common.c
> @@ -715,8 +715,8 @@ static ssize_t fsg_show_ro(struct device *dev, struct device_attribute *attr,
>                                  : curlun->initially_ro);
>  }
>
> -static ssize_t fsg_show_nofua(struct device *dev, struct device_attribute *attr,
> -                             char *buf)
> +static ssize_t __maybe_unused
> +fsg_show_nofua(struct device *dev, struct device_attribute *attr, char *buf)
>  {
>        struct fsg_lun  *curlun = fsg_lun_from_dev(dev);
>
> @@ -779,9 +779,9 @@ static ssize_t fsg_store_ro(struct device *dev, struct device_attribute *attr,
>        return rc;
>  }
>
> -static ssize_t fsg_store_nofua(struct device *dev,
> -                              struct device_attribute *attr,
> -                              const char *buf, size_t count)
> +static ssize_t __maybe_unused
> +fsg_store_nofua(struct device *dev, struct device_attribute *attr,
> +               const char *buf, size_t count)
>  {
>        struct fsg_lun  *curlun = fsg_lun_from_dev(dev);
>        unsigned long   nofua;
> --
> 1.7.1
>
>

Acked-by: Andy Shevchenko <andy.shevchenko@...il.com>

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/