| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Aug 2010 11:09:30 +0930 From: Rusty Russell <rusty@...tcorp.com.au> To: Dmitry Torokhov <dtor@...are.com> Cc: linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Len Brown <lenb@...nel.org> Subject: Re: [PATCH 1/2] param: allow omitting set() methods for truly read-only params On Wed, 11 Aug 2010 04:28:44 am Dmitry Torokhov wrote: > Certain "parameters", such as acpica version and upcoming VMware Balloon > version, are need to be purely read-only. They are exported as > parameters so that they are visible in sysfs even in cases when the > module is built directly into the kernel, but their values should be > immutable. Specifying S_IRUGO takes care of sysfs interface, but it > has no effect on kernel command line or modprobe configuration files and > so these "parameters" attempt to omit set() method. Unfortunately > kernel expects set() to be always present and crashes if it is not > there, so let's add appropriate check. > > Signed-off-by: Dmitry Torokhov <dtor@...are.com> That almost makes sense, but not quite. Your followup patch uses this for version, but the version is already in /sys/module/vmware_balloon/version as is standard with modules, no? Confused, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists