linux-kernel - Re: [PATCH] MD: raid1, fix BUG caused by flags handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Aug 2010 14:06:41 +0200
From:	Jiri Slaby <jirislaby@...il.com>
To:	Jiri Slaby <jslaby@...e.cz>
CC:	neilb@...e.de, akpm@...ux-foundation.org,
	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH] MD: raid1, fix BUG caused by flags handling

On 08/12/2010 02:01 PM, Jiri Slaby wrote:
> Commit 74450be1 (block: unify flags for struct bio and struct request)

Actually there are more than the two below introduced by the commit.
Hold on, I will post v2.

> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -787,8 +787,8 @@ static int make_request(mddev_t *mddev, struct bio * bio)
>  	struct bio_list bl;
>  	struct page **behind_pages = NULL;
>  	const int rw = bio_data_dir(bio);
> -	const bool do_sync = (bio->bi_rw & REQ_SYNC);
> -	bool do_barriers;
> +	const unsigned long do_sync = (bio->bi_rw & REQ_SYNC);
> +	unsigned long do_barriers;
>  	mdk_rdev_t *blocked_rdev;
>  
>  	/*


-- 
js
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/