linux-kernel - [PATCH] cyber2000fb: palette corruption at higher clocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 15 Aug 2010 21:51:11 +0200
From:	Ondrej Zary <linux@...nbow-software.org>
To:	"Russell King - ARM Linux" <linux@....linux.org.uk>
Cc:	linux-fbdev@...r.kernel.org,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: [PATCH] cyber2000fb: palette corruption at higher clocks

Hello,
I'm implementing EDID support for cyber2000fb and found a weird bug in
cyber2000fb driver. My monitor EDID reports 1280x1024@...z as best mode. When
this mode is set, console palette is not set properly - sometimes the
background is white, sometimes yellow and text colors are also messed up.
This does not happen at 1280x1024@...z.

When I run "reset", it fixes the palette. But when I run it immediately after
loading the driver (i.e. "modprobe cyber2000fb mode_option=1280x1024-8@75 &&
reset"), it does not help. "sleep 0.6" needs to be added before "reset" to
make it work.

It seems that the HW needs some time before setting the palette - maybe the
PLL needs more time to lock at higher speeds? Does anyone have some HW docs
to check this? This patch fixes the problem but without knowing what register
to check for PLL lock(?), the delay might be excessive.

Signed-off-by: Ondrej Zary <linux@...nbow-software.org>

--- linux-2.6.35-rc3-/drivers/video/cyber2000fb.c	2010-08-15 21:13:39.000000000 +0200
+++ linux-2.6.35-rc3/drivers/video/cyber2000fb.c	2010-08-15 21:25:20.000000000 +0200
@@ -506,6 +506,9 @@ static void cyber2000fb_set_timing(struc
 	cyber2000_grphw(0xb9, 0x80, cfb);
 	cyber2000_grphw(0xb9, 0x00, cfb);

+	/* wait (for the PLL?) to avoid palette corruption at higher clocks */
+	msleep(1000);
+
 	cfb->ramdac_ctrl = hw->ramdac;
 	cyber2000fb_write_ramdac_ctrl(cfb);

-- 
Ondrej Zary
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/