linux-kernel - perf compilation fails on Ubuntu's gcc 4.3.3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sun, 22 Aug 2010 01:07:11 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Arnaldo Carvalho de Melo <acme@...hat.com>
Cc:	Frédéric Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: perf compilation fails on Ubuntu's gcc 4.3.3

Hi,

here is what I got today trying to compile perf on my
Ubuntu system

 >    CC util/ui/util.o
 > cc1: warnings being treated as errors
 > util/ui/util.c: In function ‘ui__dialog_yesno’:
 > util/ui/util.c:108: error: not protecting function: no buffer at least 8 bytes long
 > make: *** [util/ui/util.o] Error 1

An ugly hack like

diff --git a/tools/perf/util/ui/util.c b/tools/perf/util/ui/util.c
index 9706d9d..4ef6a86 100644
--- a/tools/perf/util/ui/util.c
+++ b/tools/perf/util/ui/util.c
@@ -107,6 +107,7 @@ out_destroy_form:
 bool ui__dialog_yesno(const char *msg)
 {
        /* newtWinChoice should really be accepting const char pointers... */
-       char yes[] = "Yes", no[] = "No";
-       return newtWinChoice(NULL, yes, no, (char *)msg) == 1;
+       const char *yes = "Yes";
+       const char *no = "No";
+       return newtWinChoice(NULL, (char *)yes, (char *)no, (char *)msg) == 1;
 }

did trick for me. But the issue origin is

EXTRA_WARNINGS := $(EXTRA_WARNINGS) -Wstack-protector

What is the best way to deal with it?

 | cyrill@...ovo perf $ gcc --version
 | gcc (Ubuntu 4.3.3-5ubuntu4) 4.3.3
 | Copyright (C) 2008 Free Software Foundation, Inc.
 | This is free software; see the source for copying conditions.  There is NO
 | warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/