linux-kernel - Re: [PATCH][RESEND] fix compilation error with CROSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Aug 2010 13:36:42 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Wu Fengguang <fengguang.wu@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tiago Maluta <tiago.maluta@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][RESEND] fix compilation error with CROSS_COMPILE

On 21.8.2010 14:58, Sam Ravnborg wrote:
>> commit 7f48a0a8c15c41f382f2265088bc96007836e608
>> Author: Tiago Maluta<tiago.maluta@...il.com>
>> Date:   Mon Jun 21 22:00:17 2010 +0200
>>
>>      Linux has an recent option to define CROSS_COMPILE in menuconfig.
[...]
>> diff --git a/Makefile b/Makefile
>> index 7431c28..13126ae 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -190,7 +190,7 @@ SUBARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ \
>>   export KBUILD_BUILDHOST := $(SUBARCH)
>>   ARCH           ?= $(SUBARCH)
>>   CROSS_COMPILE  ?=
>> -CROSS_COMPILE  ?= $(CONFIG_CROSS_COMPILE:"%"=%)
>> +CROSS_COMPILE  := $(shell grep CONFIG_CROSS_COMPILE .config | cut -d'"' -f2)
>
> So this patch does two things:
> 1) It grep for CONFIG_CROSS_COMPILE because we may not have incldued .config
> 2) It no longer pick up CROSS_COMPILE from the environment.
>
> Traditionally we have picked up ARCH and CROSS_COMPILE from the environmnet,
> hence the use of "?=".
> "?=" says - perfrom this assignmnet unless lhs is already defined.
> And lhs may be already defined is we have the ysmbol defined in the
> environmnet.
>
> I think the original submitter chenged from ?= to := without
> realising this.
> So the patch should be adjusted to use ?= again as you suggest
> before it is applied.
> I assume Michal / Andrew will take care.

I would rather check if the patch is still needed at all. Tiago, can you 
try vanilla 2.6.36-rc1, which has the first
"CROSS_COMPILE  ?="
line removed (commit 235caa2) and check if your original problem still 
presists?

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/