linux-kernel - Re: [PATCH v2] mfd: tps6586x - free allocated resources when unload the module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 24 Aug 2010 17:00:37 +0800
From:	Eric Miao <eric.y.miao@...il.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Mike Rapoport <mike@...pulab.co.il>
Subject: Re: [PATCH v2] mfd: tps6586x - free allocated resources when unload
 the module

On Tue, Aug 24, 2010 at 3:18 PM, Axel Lin <axel.lin@...il.com> wrote:
> For the resources allocated in tps6586x_i2c_probe(),
> we need to free it in tps6586x_i2c_remove().
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
> Changes since V1:
> Current implementation allows gpiochip_add() fail in probe,
> thus just show a wraning if gpiochip_remove() fail.
>
> I don't have this hardware handy,
> I am not sure that does it make sense to allow gpiochip_add() fail in probe.

That's fully possible.

>
>  drivers/mfd/tps6586x.c |   13 +++++++++++++
>  1 files changed, 13 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
> index 1c91936..2f9336c 100644
> --- a/drivers/mfd/tps6586x.c
> +++ b/drivers/mfd/tps6586x.c
> @@ -344,6 +344,19 @@ err_add_devs:
>
>  static int __devexit tps6586x_i2c_remove(struct i2c_client *client)
>  {
> +       struct tps6586x *tps6586x = i2c_get_clientdata(client);
> +       struct tps6586x_platform_data *pdata = client->dev.platform_data;
> +       int ret;
> +
> +       if (pdata->gpio_base) {
> +               ret = gpiochip_remove(&tps6586x->gpio);
> +               if (ret)
> +                       dev_err(&client->dev, "Can't remove gpio chip: %d\n",
> +                               ret);
> +       }
> +
> +       tps6586x_remove_subdevs(tps6586x);
> +       kfree(tps6586x);
>        return 0;
>  }
>
> --
> 1.7.2
>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/