linux-kernel - Re: [PATCH] Add intel drm blacklist to intel_opregion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Aug 2010 15:22:19 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Joey Lee <jlee@...ell.com>
Cc:	trenn@...e.de, gregkh@...e.de, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, Dennis.Jansen@....de
Subject: Re: [PATCH] Add intel drm blacklist to intel_opregion_present
	detect

Erm. Sorry about that - I just realised that there's actually a fairly 
significant problem with it :) Right now you'll perform the register 
call unconditionally on module load. You need to make sure that there's 
actually Poulsbo hardware in the system, either by registering as a 
proper PCI driver and calling acpi_video_register in your probe function 
(and unregister in your remove function) or walking the PCI device list 
looking for a psb device.

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/