linux-kernel - Re: [PATCH] Add intel drm blacklist to intel_opregion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Aug 2010 15:58:03 +0100
From:	Matthew Garrett <mjg59@...f.ucam.org>
To:	Greg KH <gregkh@...e.de>
Cc:	Joey Lee <jlee@...ell.com>, trenn@...e.de,
	linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dennis.Jansen@....de
Subject: Re: [PATCH] Add intel drm blacklist to intel_opregion_present
	detect

On Tue, Aug 24, 2010 at 07:51:30AM -0700, Greg KH wrote:
> On Tue, Aug 24, 2010 at 03:22:19PM +0100, Matthew Garrett wrote:
> > Erm. Sorry about that - I just realised that there's actually a fairly 
> > significant problem with it :) Right now you'll perform the register 
> > call unconditionally on module load. You need to make sure that there's 
> > actually Poulsbo hardware in the system, either by registering as a 
> > proper PCI driver and calling acpi_video_register in your probe function 
> > (and unregister in your remove function) or walking the PCI device list 
> > looking for a psb device.
> 
> Ick, don't walk the pci device list, just register a "real" pci device
> and do it that way, it's much simpler and plays nicer with the driver
> model and the rest of the kernel.

My only concern with that (and it's not a strong one) is that it'll 
block the psb driver from binding. Of course, the psb driver should be 
doing the acpi handling itself anyway, so...

-- 
Matthew Garrett | mjg59@...f.ucam.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/