linux-kernel - [PATCH] hide guard page for stacks that grow upwards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Aug 2010 15:03:02 -0700
From:	"Luck, Tony" <tony.luck@...el.com>
To:	"Linus Torvalds" <torvalds@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org, linux-parisc@...r.kernel.org,
	linux-ia64@...r.kernel.org
Subject: [PATCH] hide guard page for stacks that grow upwards

pa-risc and ia64 have stacks that grow upwards. Don't
show the guard page on upward growing vma in /proc/$$/maps

Signed-off-by: Tony Luck <tony.luck@...el.com>

---

This looks useful too ... but I can't see where the code is that
made vm_start be PAGE_SIZE lower to begin with. I'd expect to have
to make a matching change to make vm_end PAGE_SIZE higher for the
VM_GROWSUP areas.

diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
index 439fc1f..ef262f6 100644
--- a/fs/proc/task_mmu.c
+++ b/fs/proc/task_mmu.c
@@ -210,7 +210,7 @@ static void show_map_vma(struct seq_file *m, struct vm_area_struct *vma)
 	int flags = vma->vm_flags;
 	unsigned long ino = 0;
 	unsigned long long pgoff = 0;
-	unsigned long start;
+	unsigned long start, end;
 	dev_t dev = 0;
 	int len;
 
@@ -223,12 +223,15 @@ static void show_map_vma(struct seq_file *m, struct vm_area_struct *vma)
 
 	/* We don't show the stack guard page in /proc/maps */
 	start = vma->vm_start;
+	end = vma->vm_end;
 	if (vma->vm_flags & VM_GROWSDOWN)
 		start += PAGE_SIZE;
+	if (vma->vm_flags & VM_GROWSUP)
+		end -= PAGE_SIZE;
 
 	seq_printf(m, "%08lx-%08lx %c%c%c%c %08llx %02x:%02x %lu %n",
 			start,
-			vma->vm_end,
+			end,
 			flags & VM_READ ? 'r' : '-',
 			flags & VM_WRITE ? 'w' : '-',
 			flags & VM_EXEC ? 'x' : '-',
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/