linux-kernel - [PATCH] i915, drm: Fix build dependency on VGA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Thu, 26 Aug 2010 16:59:18 +0200
From:	Borislav Petkov <bp@...en8.de>
To:	David Airlie <airlied@...ux.ie>
Cc:	Ben Hutchings <ben@...adent.org.uk>, Eric Anholt <eric@...olt.net>,
	Jordan Crouse <jcrouse@...eaurora.org>,
	Matthew Garrett <mjg@...hat.com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: [PATCH] i915, drm: Fix build dependency on VGA_ARB

I get:

  LD      init/built-in.o
  LD      .tmp_vmlinux1
drivers/built-in.o: In function `intel_modeset_init':
(.text+0xa993f): undefined reference to `vga_get'
drivers/built-in.o: In function `intel_modeset_init':
(.text+0xa9963): undefined reference to `vga_put'
make: *** [.tmp_vmlinux1] Error 1

since CONFIG_AGB_ARB is not being selected. Make I915 driver select it
as the numerous other things it selects.

Signed-off-by: Borislav Petkov <bp@...en8.de>
---

This is on latest Linus git (v2.6.36-rc2-237-gd4348c6) after doing `make
oldconfig' on an Acer Aspire One netbook.

 drivers/gpu/drm/Kconfig |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 4cab0c6..43590ab 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -97,6 +97,7 @@ config DRM_I830
 config DRM_I915
 	tristate "i915 driver"
 	depends on AGP_INTEL
+	select VGA_ARB
 	select SHMEM
 	select DRM_KMS_HELPER
 	select FB_CFB_FILLRECT
-- 
1.7.1


-- 
Regards/Gruss,
Boris.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/