linux-kernel - Re: [RFC PATCH 00/43] ptrace cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 29 Aug 2010 17:14:54 -0700 (PDT)
From:	Roland McGrath <roland@...hat.com>
To:	Namhyung Kim <namhyung@...il.com>
Cc:	Oleg Nesterov <oleg@...hat.com>, Arnd Bergmann <arnd@...db.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH 00/43] ptrace cleanups

I am fine with the s/long/unsigned long/ signature changes.  Adding
temporaries to avoid the repeated casts is fine too.  All that will
compile away to the same code we have now.  But please do it without
changing put_user/get_user calls to copy_{to,from}_user.  With a
temporary or two you'll still have fewer casts than before.  IMHO you
should at least do a separate follow-on patch for anything that actually
changes the compiled code vs just the cosmetic type cleanups.

Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/