linux-kernel - Re: [PATCH v4] gpio: Add driver for basic memory-mapped GPIO controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 30 Aug 2010 13:23:18 -0700 (PDT)
From:	David Brownell <david-b@...bell.net>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] gpio: Add driver for basic memory-mapped GPIO controllers



--- On Sun, 8/29/10, Anton Vorontsov <cbouatmailru@...il.com> wrote:
Brownell
> wrote:
> > But  do it without BUG()... 
> Yeah, good idea. Let's turn these BUG() into
> WARN_ON_ONCE()?

I'm not a big fan of redundant -- and
 noisy! error reports like
that:  recall that errors were already reported
(and ignored) on those paths, indicating invalid
GPIOs (requested, or direction set, etc).

The read paths should probably just return zero;
that's required in some cases, if you read the
interface spec.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/