linux-kernel - (arch_)get_unmapped_area can be terribly slow due to unnecessary linear search and find

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 30 Aug 2010 23:28:21 +0200
From:	Luca Barbieri <luca@...a-barbieri.com>
To:	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: (arch_)get_unmapped_area can be terribly slow due to unnecessary
 linear search and find_vma

[Sending copy of bug #17531 since the BTS seemingly can't/won't send it to LKML]

Currently most/all versions of get_unmapped_area perform a linear search in the
process virtual address space to find free space.

Some, like arch_get_unmapped_area_topdown for x86-64 even call find_vma for
each step, which does a full walk on the rb-tree of vmas.

Instead, they should use, from slower to faster:
- O(n) but faster: a linked list of virtual address space holes
- O(log(n)): an rb-tree of virtual address space holes indexed by size
- O(1): a buddy allocator of virtual address space holes, or another scheme
with buckets

Is there any reason this issue hasn't been fixed yet? (i.e. any reason none of
the proposed schemes are feasible?)

Workloads doing a lot of mmaps tend to suffer greatly, especially on the
versions that do a find_vma for each step of the scan.

An example are OpenGL drivers using DRM/GEM/TTM who don't employ userspace
caching and suballocation of TTM allocated buffers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/