linux-kernel - Re: [PATCH] USB: output an error message when the pipe type doesn't match the endpoint type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Aug 2010 12:31:34 +0100
From:	"Simon Arlott" <simon@...e.lp0.eu>
To:	"Clemens Ladisch" <clemens@...isch.de>
Cc:	"Greg KH" <greg@...ah.com>,
	"Alan Stern" <stern@...land.harvard.edu>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"USB list" <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] USB: output an error message when the pipe type 
 doesn't match the endpoint type

On Tue, August 31, 2010 07:41, Clemens Ladisch wrote:
> Simon Arlott wrote:
>> Commit f661c6f8c67bd55e93348f160d590ff9edf08904 adds a check of the pipe type if
>> CONFIG_USB_DEBUG is enabled,
>
> I didn't see that commit last year, but wouldn't it break devices like
> the ESI MIDI Mate whose descriptors want to have low-speed bulk transfers
> and where the driver has to submit interrupt transfers instead to get it
> to work at all?

If the transfer type doesn't match the pipe type then yes, but only when
CONFIG_USB_DEBUG is enabled.

Perhaps these need to be moved to a CONFIG_USB_STRICT. Having a "debug" mode
change the behaviour is not a good idea, but some of the code in that ifdef
has been there since the import to git.

Regardless of which configuration option enables it, the pipe type
check needs an error message to explain why the driver received -EPIPE.

-- 
Simon Arlott
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/