linux-kernel - Re: [PATCH] Staging: vt6656: Remove the ULONG_PTR and DWORD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 31 Aug 2010 11:33:43 -0700
From:	Greg KH <greg@...ah.com>
To:	Roel Van Nyen <roel.vannyen@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Forest Bond <forest@...ttletooquiet.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: vt6656: Remove the ULONG_PTR and DWORD_PTR
 defines from ttype.h

On Thu, Aug 05, 2010 at 06:23:21PM +0200, Roel Van Nyen wrote:
> I have re-done my patch and this time without any checkpatch.pl errors.

Well, some you can ignore:

> 
> Remove DWORD_PTR and ULONG_PTR from ttype.h
> 
> Signed-off-by: Roel Van Nyen <roel.vannyen@...il.com>
> ---
>  drivers/staging/vt6656/bssdb.c |    8 ++++----
>  drivers/staging/vt6656/ttype.h |    4 ----
>  2 files changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/bssdb.c b/drivers/staging/vt6656/bssdb.c
> index a9f68bd..024dff3 100644
> --- a/drivers/staging/vt6656/bssdb.c
> +++ b/drivers/staging/vt6656/bssdb.c
> @@ -466,7 +466,7 @@ BOOL BSSbInsertToBSSList(void *hDeviceContext,
>  	unsigned int uLen = pRSNWPA->len + 2;
>  
>  	if (uLen <= (uIELength -
> -		     (unsigned int) (ULONG_PTR) ((PBYTE) pRSNWPA - pbyIEs))) {
> +	(unsigned int) (unsigned long) ((PBYTE) pRSNWPA - pbyIEs))) {

That's just horrible, move it to the right like it was, just don't add
the extra spaces where they are not needed.  And think, why would you
want to cast from an unsigned long and then to an unsigned int,
something is really wrong with that code, it should be fixed properly.

Care to try again?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/