linux-kernel - Re: [PATCHv8 03/13] USB: gadget: composite: Better string override handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 1 Sep 2010 14:12:41 -0700
From:	Greg KH <greg@...ah.com>
To:	Michal Nazarewicz <m.nazarewicz@...sung.com>
Cc:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCHv8 03/13] USB: gadget: composite: Better string override
 handling

On Wed, Sep 01, 2010 at 02:10:17PM -0700, Greg KH wrote:
> On Thu, Aug 12, 2010 at 05:43:46PM +0200, Michal Nazarewicz wrote:
> > The iManufatcurer, iProduct and iSerialNumber composite module
> > parameters were only used when the gadget driver registers
> > strings for manufacturer, product and serial number.  If the
> > gadget never bothered to set corresponding fields in USB device
> > descriptors those module parameters are ignored.
> > 
> > This commit makes the parameters work even if the strings ID
> > have not been assigned.  It also changes the way IDs are
> > overridden -- what IDs are overridden is now saved in
> > usb_composite_dev structure -- which makes it unnecessary to
> > modify the string tables the way previous code did.
> > 
> > The commit also adds a iProduct and iManufatcurer fields to the
> > usb_composite_device structure.  If they are set, appropriate
> > strings are reserved and added to device descriptor.  This makes
> > it unnecessary for gadget drivers to maintain code for setting
> > those.  If iProduct is not set it defaults to
> > usb_composite_device::name; if iManufatcurer is not set
> > a default "<system> <release> with <gadget-name>" is used.
> > 
> > The last thing is that if needs_serial field of
> > usb_composite_device is set and user failed to provided
> > iSerialNumber parameter a warning is issued.
> > 
> > Signed-off-by: Michal Nazarewicz <m.nazarewicz@...sung.com>
> > Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> 
> This patch doesn't apply on the latest tree, care to respin it, and the
> ones after it as well?

Oops, my fault, nevermind, I got it fixed...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/