linux-kernel - Re: Resend: [PATCH] x86-64: fix unwind annotations in syscall stubs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 03 Sep 2010 00:50:47 +0200
From:	"Alexander van Heukelum" <heukelum@...tmail.fm>
To:	"Jan Beulich" <JBeulich@...ell.com>, "Ingo Molnar" <mingo@...e.hu>,
	"Thomas Gleixner" <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: Resend: [PATCH] x86-64: fix unwind annotations in syscall  stubs

On Thu, 02 Sep 2010 13:53 +0100, "Jan Beulich" <JBeulich@...ell.com> wrote:
> The scope should really extend to the end of the function, not the
> return location.
> 
> Signed-off-by: Jan Beulich <jbeulich@...ell.com>
> 
> ---
>  arch/x86/kernel/entry_64.S |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-2.6.36-rc3/arch/x86/kernel/entry_64.S
> +++ 2.6.36-rc3-x86_64-error_entry-unwind-scope/arch/x86/kernel/entry_64.S
> @@ -1445,7 +1445,6 @@ error_swapgs:
>  error_sti:
>  	TRACE_IRQS_OFF
>  	ret
> -       CFI_ENDPROC
>  
>  /*
>   * There are two places in the kernel that can potentially fault with
> @@ -1470,6 +1469,7 @@ bstep_iret:
>  	/* Fix truncated RIP */
>  	movq %rcx,RIP+8(%rsp)
>  	jmp error_swapgs
> +       CFI_ENDPROC
>  END(error_entry)
>  

Indeed.

Acked-by: Alexander van Heukelum <heukelum@...tmail.fm>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/