linux-kernel - RE: [PATCH v2] power supply: add driver for TI BQ20Z75 gas gauge IC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 4 Sep 2010 14:00:47 -0700
From:	Rhyland Klein <rklein@...dia.com>
To:	Anton Vorontsov <cbouatmailru@...il.com>
CC:	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"olof@...om.net" <olof@...om.net>, Andrew Chew <AChew@...dia.com>,
	"khali@...ux-fr.org" <khali@...ux-fr.org>,
	"broonie@...nsource.wolfsonmicro.com" 
	<broonie@...nsource.wolfsonmicro.com>
Subject: RE: [PATCH v2] power supply: add driver for TI BQ20Z75 gas gauge IC

Mark, have you had a chance to double check my changes based on the comments you made? 

Thanks,
Rhyland

-----Original Message-----
From: Anton Vorontsov [mailto:cbouatmailru@...il.com] 
Sent: Thursday, September 02, 2010 10:48 AM
To: Rhyland Klein
Cc: linux-i2c@...r.kernel.org; linux-kernel@...r.kernel.org; olof@...om.net; Andrew Chew; khali@...ux-fr.org; broonie@...nsource.wolfsonmicro.com
Subject: Re: [PATCH v2] power supply: add driver for TI BQ20Z75 gas gauge IC

On Thu, Sep 02, 2010 at 10:29:46AM -0700, rklein@...dia.com wrote:
> From: Rhyland Klein <rklein@...dia.com>
> 
> this driver depends on I2C and uses SMBUS for communication with the host.
> 
> Addressed comments from reviews by Mark Brown and Jean Delvare.
>   * Cleaned up whitespace and alignment issues
>   * changed return codes to more appropriate values
>   * change Kconfig option name to be consistent with existing devices
>   * removed global struct and moved to device specific data
>   * changed printk to dev_dbg

The driver looks good to me. But I'll wait a day or two for Jean's
and Mark's Acked-by or Reviewed-by tags before applying, just to
give them some credit for reviwing this driver.

Thanks!

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2