linux-kernel - Re: [PATCH 2/3] Staging: otus: added valid KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Sep 2010 19:38:05 -0700
From:	Greg KH <greg@...ah.com>
To:	"Prashant P. Shah" <pshah.mumbai@...il.com>
Cc:	Joe Perches <joe@...ches.com>, gregkh@...e.de,
	devel@...verdev.osuosl.org, daniele.boncompagni@...il.com,
	linux-kernel@...r.kernel.org, julia@...u.dk
Subject: Re: [PATCH 2/3] Staging: otus: added valid KERN_ loglevels to
	printk in wwrap.c

On Tue, Sep 07, 2010 at 08:09:53AM -0700, Joe Perches wrote:
> On Tue, 2010-09-07 at 18:44 +0530, Prashant P. Shah wrote:
> > This is a patch to the wwrap.c file that adds valid KERN_ loglevels
> > to printk() statements
> > 
> > Signed-off-by: Prashant P. Shah <pshah.mumbai@...il.com>
> > ---
> >  drivers/staging/otus/wwrap.c |   33 ++++++++++++++++-----------------
> >  1 files changed, 16 insertions(+), 17 deletions(-)
> > 
> > diff --git a/drivers/staging/otus/wwrap.c b/drivers/staging/otus/wwrap.c
> []
> > @@ -358,13 +357,13 @@ void zfLnxUsbDataIn_callback(urb_t *urb)
> >  #if 0
> >  			/* Dump data */
> >  			for (ii = index; ii < pkt_len+4;) {
> > -				printk("%02x ", (buf->data[ii] & 0xff));
> > +				printk(KERN_INFO "%02x ", (buf->data[ii] & 0xff));
> >  
> >  				if ((++ii % 16) == 0)
> > -					printk("\n");
> > +					printk(KERN_INFO "\n");
> >  			}
> >  
> > -			printk("\n");
> > +			printk(KERN_INFO "\n");
> >  #endif
> >  
> >  			pad_len = 4 - (pkt_len & 0x3);
> 
> and
> 
> > @@ -636,11 +635,11 @@ u32_t zfLnxUsbSubmitTxData(zdev_t *dev)
> >  	if (TxData->hdrlen != 0) {
> >  		puTxBuf = macp->txUsbBuf[freeTxUrb];
> >  		for (i = 0; i < len; i++) {
> > -			printk("%02x ", puTxBuf[i]);
> > +			printk(KERN_INFO "%02x ", puTxBuf[i]);
> >  			if (i % 16 == 15)
> > -				printk("\n");
> > +				printk(KERN_INFO "\n");
> >  		}
> > -		printk("\n");
> > +		printk(KERN_INFO "\n");
> 
> These should use KERN_CONT.
> 
> It'd be better to use print_hex_dump() instead.

Yes, I can't accept this patch, it is incorrect.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/