linux-kernel - Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Sep 2010 22:37:48 +0900
From:	"Masayuki Ohtake" <masa-korg@....okisemi.com>
To:	"Stephen Hemminger" <shemminger@...tta.com>,
	"Jiri Slaby" <jslaby@...e.cz>
Cc:	"Randy Dunlap" <randy.dunlap@...cle.com>,
	"Ralf Baechle" <ralf@...ux-mips.org>,
	"ML netdev" <netdev@...r.kernel.org>,
	"MeeGo" <meego-dev@...go.com>, "Maxime Bizon" <mbizon@...ebox.fr>,
	"LKML" <linux-kernel@...r.kernel.org>,
	"Kristoffer Glembo" <kristoffer@...sler.com>,
	"John Linn" <john.linn@...inx.com>,
	"Joe Perches" <joe@...ches.com>,
	"Greg Rose" <gregory.v.rose@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	"Wang, Yong Y" <yong.y.wang@...el.com>,
	"Wang, Qi" <qi.wang@...el.com>,
	"Toshiharu Okada" <okada533@....okisemi.com>,
	"Tomoya Morinaga" <morinaga526@....okisemi.com>,
	"Takahiro Shimizu" <shimizu394@....okisemi.com>,
	"Intel OTC" <joel.clark@...el.com>,
	"Foster, Margie" <margie.foster@...el.com>,
	"Andrew" <andrew.chih.howe.khor@...el.com>
Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH

On Wed, 8 Sep 2010 07:55:45 -0700
Stephen Hemminger <shemminger@...tta.com> wrote:
>
> Better yet:
> rxdr->count = clamp_val(ring->rx_pending,
> PCH_GBE_MIN_RXD,
> PCH_GBE_MAX_RXD);

Hi Stephen

Thank you for your suggestion.
I will modify like your suggestion.
.
Thanks, Ohtake
----- Original Message ----- 
From: "Stephen Hemminger" <shemminger@...tta.com>
To: "Jiri Slaby" <jslaby@...e.cz>
Cc: "Masayuki Ohtake" <masa-korg@....okisemi.com>; "Randy Dunlap" <randy.dunlap@...cle.com>; "Ralf Baechle"
<ralf@...ux-mips.org>; "ML netdev" <netdev@...r.kernel.org>; "MeeGo" <meego-dev@...go.com>; "Maxime Bizon"
<mbizon@...ebox.fr>; "LKML" <linux-kernel@...r.kernel.org>; "Kristoffer Glembo" <kristoffer@...sler.com>; "John Linn"
<john.linn@...inx.com>; "Joe Perches" <joe@...ches.com>; "Greg Rose" <gregory.v.rose@...el.com>; "David S. Miller"
<davem@...emloft.net>; "Wang, Yong Y" <yong.y.wang@...el.com>; "Wang, Qi" <qi.wang@...el.com>; "Toshiharu Okada"
<okada533@....okisemi.com>; "Tomoya Morinaga" <morinaga526@....okisemi.com>; "Takahiro Shimizu"
<shimizu394@....okisemi.com>; "Intel OTC" <joel.clark@...el.com>; "Foster, Margie" <margie.foster@...el.com>; "Andrew"
<andrew.chih.howe.khor@...el.com>
Sent: Wednesday, September 08, 2010 11:55 PM
Subject: Re: [PATCH] Gigabit Ethernet driver of Topcliff PCH


> On Wed, 08 Sep 2010 16:16:11 +0200
> Jiri Slaby <jslaby@...e.cz> wrote:
>
> > >>> +
> > >>> + rxdr->count = max(ring->rx_pending, (u32) PCH_GBE_MIN_RXD);
> > >>> + rxdr->count = min(rxdr->count, (u32) PCH_GBE_MAX_RXD);
> > >>
> > >> clamp()
> > >> And why you need the cast?
> > >
> > > [masa]
> > > Since warning appears at the time of a make.
> >
> > OK, then you have type error which you should fix instead. Perhaps
> > define the constnts with U suffix?
>
> Better yet:
> rxdr->count = clamp_val(ring->rx_pending,
> PCH_GBE_MIN_RXD,
> PCH_GBE_MAX_RXD);
>
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/