linux-kernel - Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 10 Sep 2010 02:28:27 +0900
From:	venki kaps <venkiece2005@...il.com>
To:	balbi@...com
Cc:	Ming Lei <tom.leiming@...il.com>,
	"greg@...ah.com" <greg@...ah.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Felipe Balbi <me@...ipebalbi.com>,
	"Gadiyar, Anand" <gadiyar@...com>
Subject: Re: [PATCH] USB: otg: twl4030: fix phy initialization(v1)

Venkii,

On Thu, Sep 9, 2010 at 3:01 PM, Felipe Balbi <balbi@...com> wrote:
> On Wed, Sep 08, 2010 at 08:49:08PM -0500, Ming Lei wrote:
>>
>> 2010/9/8 venki kaps <venkiece2005@...il.com>:
>>
>>>  To resolve the above issue, we have made "PHY power on" in battery
>>> adc on function
>>>  and "PHY power down" in battery adc off function.
>>
>> Good news, the temperature is bad value from battery adc if otg phy is
>> power
>> down. Maybe you only need to power on otg phy before reading battery adc,
>> then
>> power down otg phy after the reading if no usb calbe is connected with
>> musb
>> for decreasing power consumption. (I am not familiar with battery adc,
>> just
>> for your refrerence)
>
> I think you only need the usb3v1 regulator. And it can even be in sleep
> mode, it doens't have to be on. What I would suggest is that usb3v1
> never to be turned off, only .

If usb3v1 put in sleep mode, then
how about VUSB3V1 real activation?
I have tried to put in sleep by using
"twl_i2c_write_u8(TWL4030_MODULE_PM_RECEIVER, 1, VUSB_DEDICATED2);"
but still, i have been facing the issue with battery.

one thing i have not understood, why it requires to power down when
the device is booted without
a USB cable?

I have not faced any issue with Kernel 2.6.29 + same hardware
+ the same driver but the problem is facing with Kernel 2.6.32.

I strongly suspecting the problem with PMIC regulator frame work/Power
Management
since in off mode, it is getting very good power results but if system
hits INACTIVE to RETENTION during playback then power numbers will be
more
when it is booted without USB cable.

After booting, just attach/detach the usb cable, then i have not seen
any issue with power numbers in off mode, RETENTION and active states.

> --
> balbi
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/