[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 09 Sep 2010 12:33:28 -0700
From: Joe Perches <joe@...ches.com>
To: Mike Frysinger <vapier.adi@...il.com>
Cc: LKML <linux-kernel@...r.kernel.org>
Subject: Re: [rfc patch] treewide: Convert "static const char <*> foo[] ="
to "static const char <*> const foo[] ="
On Thu, 2010-09-09 at 15:16 -0400, Mike Frysinger wrote:
> On Thu, Sep 9, 2010 at 14:48, Joe Perches wrote:
> > could be warned by checkpatch
> i dont think you even need to check the contents. just match the base:
> char foo[]
> const char *foo[]
> we want to catch these even if it isnt static, and catching the
> forward decl would be useful too.
I think that's not so good.
There are times when a default is used but then modified.
For instance:
drivers/staging/comedi/drivers/comedi_bond.c: char file[] = "/dev/comediXXXXXX";
> your perl hack isnt quite right.
The script I posted doesn't eat that whitespace.
The diff I sent you did. I wouldn't post that.
> how about making a coccinelle patch ?
Not necessary I think.
If Julia or anyone else wants to, no objection.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists