linux-kernel - Re: [PATCH] exec: don't turn PF_KTHREAD off when command not found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Sep 2010 22:39:20 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Roland McGrath <roland@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] exec: don't turn PF_KTHREAD off when command not found

On 09/09, KOSAKI Motohiro wrote:
>
> I guess this is only theorical issue because now any kthread don't
> call do_execve() directly.

Yes, I think that kthread should always exit if exec fails.
Otherwise we can "trust" the thread, just suppose that exec fails
after exec_mmap() succeeds.

But,

> but anyway fixing would be better.

Agreed. It looks better if we clear PF_KTHREAD after the point-of-no-return,
and the patch saves one ->flags modification.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/