linux-kernel - Re: 2.6.36-rc3: EIP is at scsi_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Sep 2010 17:12:37 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Alexey Dobriyan <adobriyan@...il.com>,
	FUJITA Tomonori <fujita.tomonori@....ntt.co.jp>,
	Jens Axboe <jaxboe@...ionio.com>
Cc:	akpm@...ux-foundation.org, James.Bottomley@...e.de,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: 2.6.36-rc3: EIP is at scsi_init_io+...

Hmm. No noise about this one.

Jens, Fujita, James, any comments?

On Mon, Aug 30, 2010 at 11:46 AM, Alexey Dobriyan <adobriyan@...il.com> wrote:
> Not much of a calltrace, it scrolled away because of hardlockup detector.
> On the bright side, radeon KMS worked correctly and actually showed it.
>
> $ addr2line -e vmlinux ffffffff812d207b
> drivers/scsi/scsi_lib.c:1015
>
>  1012  err_exit:
>  1013          scsi_release_buffers(cmd);
>  1014          scsi_put_command(cmd);
>  1015  ===>    cmd->request->special = NULL; <===
>  1016          return error;
>  1017  }
>  1018  EXPORT_SYMBOL(scsi_init_io);

I do have to say that it looks rather wrong that it accesses "cmd"
after it has done the "scsi_put_command(cmd)" on it.

I also note that that was introduced pretty recently by commit
610a63498f7 ("scsi: fix discard page leak"), merged during this merge
window. That does look suspicious to me.

                    Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/