linux-kernel - Re: [PATCH] USB: isp1362-hcd: Removes CONFIG_USB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 9 Sep 2010 19:04:58 -0400
From:	Mike Frysinger <vapier@...too.org>
To:	Javier Martinez Canillas <martinez.javier@...il.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Lothar Wassmann <LW@...o-electronics.de>,
	Julia Lawall <julia@...u.dk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: isp1362-hcd: Removes CONFIG_USB_OTG dependent code,
 fix build breakage

On Thu, Sep 9, 2010 at 17:31, Javier Martinez Canillas wrote:
> In today linux-next I got a compile error on usb/host/isp1362-hcd:
>
> drivers/usb/host/isp1362-hcd.c: In function ‘isp1362_hub_control’:
> drivers/usb/host/isp1362-hcd.c:1680: error: ‘ohci’ undeclared (first use in this function)
>
> The problem is when the CONFIG_USB_OTG option is enabled.
>
> ohci variable is never declared and there isn't any CONFIG_USB_OTG dependent code
> besides the portion defined in isp1362_hub_control.
>
> So I think that maybe USB OTG support is not needed/supported.
>
> This patch removes the CONFIG_USB_OTG dependent block so the driver can compile cleanly.

i dont believe we've ever used OTG (or if our test board is even wired
up to support it), so this is fine by me.  let the guy who actually
uses OTG worry about it.  presumably no one has yet if it doesnt even
compile ...
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/