linux-kernel - Re: [RFC] annotating the remaining BKL users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 8 Sep 2010 17:20:57 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	John Kacur <jkacur@...hat.com>,
	Sam Ravnborg <sam@...nborg.org>, Jan Blunck <jblunck@...e.de>,
	linux-kernel@...r.kernel.org, David Miller <davem@...emloft.net>
Subject: Re: [RFC] annotating the remaining BKL users

On Wed, Sep 8, 2010 at 1:55 PM, Arnd Bergmann <arnd@...db.de> wrote:
>
> I'd like to hear preferences for one approach or the other,
> especially from Linus, so we can give this some better testing
> in -next before the merge window.

Hmm. I like your patch. It seems to have a good balance of "select
BKL" (for architectures that require it for some reason) and "depends
on BKL" (for individual modules).

That said, I'd also like to see a comment _why_ the architectures in
question depends on the BKL. Some of those look pretty historical (the
sparc32 register window spill code? Does it _really_ need the BKL at
all, or is that just a remnant of "let's get the BKL at each kernel
entry").

So with the added rule that "each select BKL needs a quick comment
why", I'd be happy with it. And maybe it would make people take a
second look.

                             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/