linux-kernel - Re: [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs attribute with update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Sep 2010 17:14:43 +0200
From:	Jean Delvare <khali@...ux-fr.org>
To:	Guenter Roeck <guenter.roeck@...csson.com>
Cc:	Randy Dunlap <rdunlap@...otime.net>, lm-sensors@...sensors.org,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] hwmon: (adm1031) Replace update_rate sysfs
 attribute with update_interval

On Wed, 15 Sep 2010 19:07:14 -0700, Guenter Roeck wrote:
> The attribute reflects an interval, not a rate.
> 
> Signed-off-by: Guenter Roeck <guenter.roeck@...csson.com>
> ---
>  Documentation/hwmon/sysfs-interface |   12 +++++-----
>  drivers/hwmon/adm1031.c             |   43 +++++++++++++++++++---------------
>  2 files changed, 30 insertions(+), 25 deletions(-)
> 
> diff --git a/Documentation/hwmon/sysfs-interface b/Documentation/hwmon/sysfs-interface
> index ff45d1f..df0cdd2 100644
> --- a/Documentation/hwmon/sysfs-interface
> +++ b/Documentation/hwmon/sysfs-interface
> @@ -91,13 +91,13 @@ name		The chip name.
>  		I2C devices get this attribute created automatically.
>  		RO
>  
> -update_rate	The rate at which the chip will update readings.
> -		Unit: millisecond
> +update_interval	The interval at which the chip or driver will update readings.

I think I prefer the original wording. The attribute is really about
setting the register refresh rate at the hardware level. The fact that
register cache lifetime in the driver can be adjusted accordingly is an
optional implementation detail IMHO.

> +		Unit: milliseconds

Why change? All other units are singular in the file.

>  		RW
> -		Some devices have a variable update rate. This attribute
> -		can be used to change the update rate to the desired
> -		frequency.
> -

Killing an innocent blank line ;)

> +		Some devices have a variable update rate or interval.
> +		Some drivers may want to make the update interval configurable
> +		instead of using a hardcoded value. This attribute can be used
> +		to change the update interval to the desired value.
>  
>  ************
>  * Voltages *

I'm fine with all the rest.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/