linux-kernel - Re: [PATCH] x86: fix duplicate calls of the nmi handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 17 Sep 2010 12:37:23 +0400
From:	Cyrill Gorcunov <gorcunov@...il.com>
To:	Robert Richter <robert.richter@....com>
Cc:	Peter Zijlstra <peterz@...radead.org>,
	Huang Ying <ying.huang@...el.com>, Ingo Molnar <mingo@...e.hu>,
	Don Zickus <dzickus@...hat.com>,
	"fweisbec@...il.com" <fweisbec@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Lin, Ming M" <ming.m.lin@...el.com>,
	"yinghai@...nel.org" <yinghai@...nel.org>,
	"andi@...stfloor.org" <andi@...stfloor.org>,
	"eranian@...gle.com" <eranian@...gle.com>
Subject: Re: [PATCH] x86: fix duplicate calls of the nmi handler

On Fri, Sep 17, 2010 at 10:13:58AM +0200, Robert Richter wrote:
> On 17.09.10 03:52:16, Peter Zijlstra wrote:
> > On Fri, 2010-09-17 at 08:13 +0800, Huang Ying wrote:
> > 
> > > Please take a look at my recent patch that rewrites the NMI handler.
> > 
> > (Link would have been useful)
> > 
> > > Where NMI are divided into two types. CPU specific NMI are processed
> > > firstly as DIE_NMI_IPI, and non-CPU specific NMI are processed as
> > > DIE_NMI.
> > 
> > OK, and you can discriminate between these two by means of that reason
> > port? Still I think NMI_IPI is a terrible name for that.
> 
> I think the current implementation that devides into NMI and NMI_IPI
> is just to keep a certain order when calling the handlers - handling
> local NMIs before non-CPU NMIs.
> 
...

This DIE_NMI_IPI definitely strange. Perhaps we could rename it to something
more understandable and implement separate notifier chain for it so that
code would not need to check if (... != DIE_NMI_IPI). Hm?

	-- Cyrill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/