linux-kernel - Re: [PATCH] hid: 3m: Output proper orientation range

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 19 Sep 2010 16:23:44 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Jiri Kosina <jkosina@...e.cz>, Stephane Chatty <chatty@...c.fr>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hid: 3m: Output proper orientation range

On Sun, Sep 19, 2010 at 10:56:23AM +0200, Henrik Rydberg wrote:
> The range of orientation values for height/width devices should
> be [0, 1], but is currently set to [1, 1]. Having min == max also
> breaks uinput device setup. Fixed with this patch.
> 
> Signed-off-by: Henrik Rydberg <rydberg@...omail.se>

Makes sense.

Acked-by: Dmitry Torokhov <dtor@...l.ru>

> ---
>  drivers/hid/hid-3m-pct.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/hid/hid-3m-pct.c b/drivers/hid/hid-3m-pct.c
> index cd4b125..860d47c 100644
> --- a/drivers/hid/hid-3m-pct.c
> +++ b/drivers/hid/hid-3m-pct.c
> @@ -110,7 +110,7 @@ static int mmm_input_mapping(struct hid_device *hdev, struct hid_input *hi,
>  			input_set_abs_params(hi->input, ABS_MT_TOUCH_MINOR,
>  					     f1, f2, df / SN_WIDTH, 0);
>  			input_set_abs_params(hi->input, ABS_MT_ORIENTATION,
> -					1, 1, 0, 0);
> +					0, 1, 0, 0);
>  			return 1;
>  		case HID_DG_CONTACTID:
>  			field->logical_maximum = MAX_TRKID;
> -- 
> 1.7.1
> 

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/