linux-kernel - Re: [PATCH 2/6] Add IRQ_TIME_ACCOUNTING, finer accounting of CPU irq time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 19 Sep 2010 13:42:40 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Venkatesh Pallipadi <venki@...gle.com>
Cc:	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux-kernel@...r.kernel.org, Paul Turner <pjt@...gle.com>
Subject: Re: [PATCH 2/6] Add IRQ_TIME_ACCOUNTING, finer accounting of CPU
 irq time

On Sun, 2010-09-19 at 13:21 +0200, Peter Zijlstra wrote:
> On Thu, 2010-09-16 at 18:56 -0700, Venkatesh Pallipadi wrote:
> > +void account_system_vtime(struct task_struct *tsk)
> > +{
> > +       unsigned long flags;
> > +       int cpu;
> > +       u64 now, delta;
> > +
> > +       if (!sched_clock_irqtime)
> > +               return;
> > +
> > +       local_irq_save(flags);
> > +
> > +       cpu = task_cpu(tsk);
> > +       now = sched_clock();
> > +       delta = now - per_cpu(irq_start_time, cpu);
> > +       per_cpu(irq_start_time, cpu) = now;
> > +       if (hardirq_count())
> > +               per_cpu(cpu_hardirq_time, cpu) += delta;
> > +       else if (softirq_count())
> > +               per_cpu(cpu_softirq_time, cpu) += delta;
> > +
> > +       local_irq_restore(flags);
> > +} 
> 
> This seems to suggest you count time double if a hardirq hits while
> we're doing softirqs, but being as this is an incomplete api its very
> hard to tell indeed.

Argh, so this function is called on both _enter and _exit, egads.

Imagine the following in task context:

  local_bh_disable();

  <IRQ>

  local_bh_enable();

That seems to incorrectly inflate softirq_time.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/