linux-kernel - Re: [PATCH] RTC: rtc-ab3100 - Add missing platform_set_drvdata() in ab3100_rtc_probe()

Open Source and information security mailing list archives

Date:	Mon, 20 Sep 2010 10:00:04 +0800
From:	Wan ZongShun <mcuos.com@...il.com>
To:	Axel Lin <axel.lin@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Mattias Wallin <mattias.wallin@...ricsson.com>,
	Linus Walleij <linus.walleij@...ricsson.com>,
	rtc-linux@...glegroups.com
Subject: Re: [PATCH] RTC: rtc-ab3100 - Add missing platform_set_drvdata() in ab3100_rtc_probe()

Hi Axel ,

2010/9/19 Axel Lin <axel.lin@...il.com>:
> Otherwise, calling platform_get_drvdata() in ab3100_rtc_remove() return NULL.
>
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Acked-by:Wan ZongShun <mcuos.com@...il.com>

> ---
>  drivers/rtc/rtc-ab3100.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/rtc/rtc-ab3100.c b/drivers/rtc/rtc-ab3100.c
> index d26780e..261a07e 100644
> --- a/drivers/rtc/rtc-ab3100.c
> +++ b/drivers/rtc/rtc-ab3100.c
> @@ -235,6 +235,7 @@ static int __init ab3100_rtc_probe(struct platform_device *pdev)
>                err = PTR_ERR(rtc);
>                return err;
>        }
> +       platform_set_drvdata(pdev, rtc);
>
>        return 0;
>  }
> @@ -244,6 +245,7 @@ static int __exit ab3100_rtc_remove(struct platform_device *pdev)
>        struct rtc_device *rtc = platform_get_drvdata(pdev);
>
>        rtc_device_unregister(rtc);
> +       platform_set_drvdata(pdev, NULL);
>        return 0;
>  }
>
> --
> 1.7.0.4
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>


-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@...ts.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@...glegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives