| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Sep 2010 06:43:54 -0600 From: Jonathan Corbet <corbet@....net> To: Florian Tobias Schandinat <FlorianSchandinat@....de> Cc: linux-fbdev@...r.kernel.org, linux-kernel@...r.kernel.org, Joseph Chan <JosephChan@....com.tw> Subject: Re: [PATCH 05/12] viafb: fix i2c_transfer error handling On Sun, 19 Sep 2010 07:33:46 +0000 Florian Tobias Schandinat <FlorianSchandinat@....de> wrote: > i2c_transfer returns negative errno on error and number of messages > processed on success. Just returning this value would give a poor > interface as it is not obvious that you must compare with 2 after reading > 1 or n bytes and with 1 after writing 1 byte to determine if it was > successful. To avoid this error prone interface convert the error code > of a successful read/write to zero and all other non-negative values to > an negative error code. > This fixes a regression introduced by > via: Rationalize vt1636 detection > which resulted in no longer detecting a VT1636 chip and therefore has > broken the output in configurations wich contain this chip. >From a quick look, all of these patches look like improvements to me. This one, since it's a regression fix, should probably have a Cc: stable@...nel.org in it as well. Acked-by: Jonathan Corbet <corbet@....net> jon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists