linux-kernel - Re: [PATCH 08/13] fs/seq_file.c: Remove unnecessary casts of private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 23 Sep 2010 13:29:18 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Joe Perches <joe@...ches.com>
Cc:	Alexander Viro <viro@...iv.linux.org.uk>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/13] fs/seq_file.c: Remove unnecessary casts of
 private_data

On Sat, 4 Sep 2010, Joe Perches wrote:

> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  fs/seq_file.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/seq_file.c b/fs/seq_file.c
> index e1f437b..0e7cb13 100644
> --- a/fs/seq_file.c
> +++ b/fs/seq_file.c
> @@ -131,7 +131,7 @@ Eoverflow:
>   */
>  ssize_t seq_read(struct file *file, char __user *buf, size_t size, loff_t *ppos)
>  {
> -	struct seq_file *m = (struct seq_file *)file->private_data;
> +	struct seq_file *m = file->private_data;
>  	size_t copied = 0;
>  	loff_t pos;
>  	size_t n;
> @@ -280,7 +280,7 @@ EXPORT_SYMBOL(seq_read);
>   */
>  loff_t seq_lseek(struct file *file, loff_t offset, int origin)
>  {
> -	struct seq_file *m = (struct seq_file *)file->private_data;
> +	struct seq_file *m = file->private_data;
>  	loff_t retval = -EINVAL;
>  
>  	mutex_lock(&m->lock);
> @@ -324,7 +324,7 @@ EXPORT_SYMBOL(seq_lseek);
>   */
>  int seq_release(struct inode *inode, struct file *file)
>  {
> -	struct seq_file *m = (struct seq_file *)file->private_data;
> +	struct seq_file *m = file->private_data;
>  	kfree(m->buf);
>  	kfree(m);
>  	return 0;

Doesn't seem to be present in linux-next as of today. I am going to fold 
it into trivial queue, if anyone has any objections, shout now.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/