linux-kernel - Re: [PATCH 04/13] drivers/s390: Remove unnecessary casts of private

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 23 Sep 2010 13:42:01 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Joe Perches <joe@...ches.com>
Cc:	Martin Schwidefsky <schwidefsky@...ibm.com>,
	Heiko Carstens <heiko.carstens@...ibm.com>,
	linux390@...ibm.com, linux-s390@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/13] drivers/s390: Remove unnecessary casts of
 private_data

On Sat, 4 Sep 2010, Joe Perches wrote:

> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/s390/char/vmcp.c |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/s390/char/vmcp.c b/drivers/s390/char/vmcp.c
> index 04e532e..19a14d9 100644
> --- a/drivers/s390/char/vmcp.c
> +++ b/drivers/s390/char/vmcp.c
> @@ -47,7 +47,7 @@ static int vmcp_release(struct inode *inode, struct file *file)
>  {
>  	struct vmcp_session *session;
>  
> -	session = (struct vmcp_session *)file->private_data;
> +	session = file->private_data;
>  	file->private_data = NULL;
>  	free_pages((unsigned long)session->response, get_order(session->bufsize));
>  	kfree(session);
> @@ -94,7 +94,7 @@ vmcp_write(struct file *file, const char __user *buff, size_t count,
>  		return -EFAULT;
>  	}
>  	cmd[count] = '\0';
> -	session = (struct vmcp_session *)file->private_data;
> +	session = file->private_data;
>  	if (mutex_lock_interruptible(&session->mutex)) {
>  		kfree(cmd);
>  		return -ERESTARTSYS;
> @@ -136,7 +136,7 @@ static long vmcp_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
>  	int __user *argp;
>  	int temp;
>  
> -	session = (struct vmcp_session *)file->private_data;
> +	session = file->private_data;
>  	if (is_compat_task())
>  		argp = compat_ptr(arg);
>  	else

Not present in linux-next as of today. Applied, thanks.

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/