lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 25 Sep 2010 12:44:36 +0900 From: Namhyung Kim <namhyung@...il.com> To: Al Viro <viro@...iv.linux.org.uk> Cc: Oleg Nesterov <oleg@...hat.com>, Roland McGrath <roland@...hat.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH RESEND] signal: annotate siglock acquisition On Sat, Sep 25, 2010 at 12:26, Al Viro <viro@...iv.linux.org.uk> wrote: > On Sat, Sep 25, 2010 at 12:20:56PM +0900, Namhyung Kim wrote: >> lock_task_sighand() conditionally acquires sighand->siglock in case of >> returning non-NULL but unlock_task_sighand() releases it unconditionally. >> This leads sparse to complain about the lock context imbalance. Annotate it >> to make sparse happier. > > That's not a good way to do it; use __cond_lock instead. > Thanks. I'll resend a patch that uses it. -- Regards, Namhyung Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists