linux-kernel - [Patch] fsnotify: remove alignment padding from fsnotify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 28 Sep 2010 15:00:02 +0100
From:	Richard Kennedy <richard@....demon.co.uk>
To:	Eric Paris <eparis@...hat.com>
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: [Patch] fsnotify: remove alignment padding from fsnotify_mark on
 64 bit builds

Reorder struct fsnotfiy_mark to remove 8 bytes of alignment padding on
64 bit builds.
Shrinks fsnotfiy_mark to 128 bytes allowing more objects per slab in its
kmem_cache and reduces the number of cachelines needed for each
structure.
    
Signed-off-by: Richard Kennedy <richard@....demon.co.uk>
----

Hi Eric,
patch against 2.6.36-rc5
compiled & booted on x86_64.

I'm not sure how to test this, but it boots and I think it's safe to
make this change.

regards
Richard



diff --git a/include/linux/fsnotify_backend.h b/include/linux/fsnotify_backend.h
index e40190d..369bed5 100644
--- a/include/linux/fsnotify_backend.h
+++ b/include/linux/fsnotify_backend.h
@@ -275,8 +275,8 @@ struct fsnotify_mark {
 		struct fsnotify_inode_mark i;
 		struct fsnotify_vfsmount_mark m;
 	};
-	__u32 ignored_mask;		/* events types to ignore */
 	struct list_head free_g_list;	/* tmp list used when freeing this mark */
+	__u32 ignored_mask;		/* events types to ignore */
 #define FSNOTIFY_MARK_FLAG_INODE		0x01
 #define FSNOTIFY_MARK_FLAG_VFSMOUNT		0x02
 #define FSNOTIFY_MARK_FLAG_OBJECT_PINNED	0x04


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/