linux-kernel - Re: [GIT PULL for 2.6.36] V4L/DVB fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 27 Sep 2010 17:02:37 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Media Mailing List <linux-media@...r.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL for 2.6.36] V4L/DVB fixes

On Mon, Sep 27, 2010 at 1:57 PM, Mauro Carvalho Chehab
<mchehab@...hat.com> wrote:
> The following changes since commit 32163f4b2cef28a5aab8b226ffecfc6379a53786:
>
>  alpha: fix usp value in multithreaded coredumps (2010-09-25 14:38:13 -0700)
>
> are available in the git repository at:
>  ssh://master.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-2.6.git v4l_for_linus

I get

  scripts/kconfig/conf --oldconfig arch/x86/Kconfig
  drivers/media/Kconfig:146: 'endif' in different file than 'if'
  drivers/media/IR/Kconfig:15: location of the 'if'
  drivers/Kconfig:114: unexpected 'endmenu' within if block
  drivers/Kconfig:1: missing end statement for this entry
  make[1]: *** [oldconfig] Error 1
  make: *** [oldconfig] Error 2

with this. And it seems to be due to a totally broken commit at the
very beginning of the series by a commit called "Kconfig fixes"
(Hah!), that clearly has not been tested at all.

The commit sequence was also done today, apparently immediately before
sending me the pull request. Which sure as hell explains the "clearly
not tested at all" situation.

Don't do this. You are now officially on my shit-list for sending me
total crap.

How effing hard can it be to understand: you don't send me stuff that
hasn't been tested. It needs to be in -next for SEVERAL DAYS, and you
don't rebase it or take it from some random quilt series just before
sending it to me.

That's true _especially_ during the -rc series. But it's damn well
true at any other time too.

I'm angry. I expect at least some _minimal_ amount of competence from
people I pull from. This was not it. Get your ^&#! act together!

                                   Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/