linux-kernel - Re: [PATCH 1/7] SPI: add PrimeCell generic DMA to PL022 v12

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 29 Sep 2010 13:54:11 +0200
From:	Linus Walleij <linus.walleij@...ricsson.com>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	Dan Williams <dan.j.williams@...el.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"yuanyabin1978@...a.com" <yuanyabin1978@...a.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/7] SPI: add PrimeCell generic DMA to PL022 v12

Grant Likely wrote:

> On Tue, Sep 28, 2010 at 04:33:55PM +0200, Linus Walleij wrote:

>> This extends the PL022 SSP/SPI driver with generic DMA engine
>> support using the PrimeCell DMA engine interface. Also fix up the
>> test code for the U300 platform.
>> (...)
>> --- a/arch/arm/mach-u300/dummyspichip.c
>> +++ b/arch/arm/mach-u300/dummyspichip.c
>> @@ -267,6 +267,7 @@ static struct spi_driver pl022_dummy_driver = {
>>  	.driver = {
>>  		.name	= "spi-dummy",
>>  		.owner	= THIS_MODULE,
>> +		.bus = &spi_bus_type,
> 
> This shouldn't be necessary.  spi_register_driver already sets the bus
> type field.
> 
> Otherwise, this patch looks good.  If you're okay with me dropping
> this hunk, then I'll pick up this patch into my next-spi branch.

OK just drop it, thanks Grant.

I need to come up with the right way to refactor that dummychip anyway
to I'll churn it out completely sooner or later.

Yours,
Linus Walleij

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/