linux-kernel - RE: [PATCH] mrst_max3110: Missing linux/irq.h include.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 30 Sep 2010 02:44:00 +0800
From:	"Tang, Feng" <feng.tang@...el.com>
To:	David Miller <davem@...emloft.net>,
	"gregkh@...e.de" <gregkh@...e.de>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] mrst_max3110: Missing linux/irq.h include.

Looks good to me, thanks for fixing it.

- Feng
-----Original Message-----
From: David Miller [mailto:davem@...emloft.net] 
Sent: Tuesday, September 28, 2010 11:36 PM
To: gregkh@...e.de
Cc: Tang, Feng; linux-kernel@...r.kernel.org
Subject: [PATCH] mrst_max3110: Missing linux/irq.h include.


This driver makes use of IRQ_TYPE_EDGE_FALLING, therefore it must
include linux/irq.h

drivers/serial/mrst_max3110.c: In function 'serial_m3110_startup':
drivers/serial/mrst_max3110.c:470:5: error: 'IRQ_TYPE_EDGE_FALLING' undeclared (first use in this function)
drivers/serial/mrst_max3110.c:470:5: note: each undeclared identifier is reported only once for each function it appears in

Signed-off-by: David S. Miller <davem@...emloft.net>

diff --git a/drivers/serial/mrst_max3110.c b/drivers/serial/mrst_max3110.c
index f6ad1ec..915dedc 100644
--- a/drivers/serial/mrst_max3110.c
+++ b/drivers/serial/mrst_max3110.c
@@ -33,6 +33,7 @@
 #include <linux/console.h>
 #include <linux/sysrq.h>
 #include <linux/platform_device.h>
+#include <linux/irq.h>
 #include <linux/tty.h>
 #include <linux/tty_flip.h>
 #include <linux/serial_core.h>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/