linux-kernel - RE: [PATCH 1/3] TPM: new stm i2c device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Oct 2010 16:27:14 +0200
From:	Christophe Henri RICARD <christophe-h.ricard@...com>
To:	James Morris <jmorris@...ei.org>,
	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"joe@...ches.com" <joe@...ches.com>
Subject: RE: [PATCH 1/3] TPM: new stm i2c device driver

Hi James,

Which kernel are you using ?
I have made my testing with a 2.6.35.4 kernel.
As far as I know kernel 2.6.36 will not provide any ioctl field any more.
May be this is the reason ?

Please let me know.
Thanks
Christophe

-----Original Message-----
From: James Morris [mailto:jmorris@...ei.org] 
Sent: Thursday, September 30, 2010 7:51 PM
To: Rajiv Andrade
Cc: linux-kernel@...r.kernel.org; joe@...ches.com; Christophe Henri RICARD
Subject: Re: [PATCH 1/3] TPM: new stm i2c device driver

On Thu, 30 Sep 2010, Rajiv Andrade wrote:

> From: Christophe Henri RICARD <christophe-h.ricard@...com>
> 
> This driver uses the Linux I2C, TPM and generic gpio interfaces.
> 
> Signed-off-by: Christophe Henri RICARD <christophe-h.ricard@...com>
> Signed-off-by: Rajiv Andrade <srajiv@...ux.vnet.ibm.com>

This does not look to have been compile tested against my tree:

 CC [M]  drivers/char/tpm/tpm_stm_st19_i2c.o
drivers/char/tpm/tpm_stm_st19_i2c.c:574: error: unknown field ioctl specified in initializer
drivers/char/tpm/tpm_stm_st19_i2c.c:574: warning: initialization from incompatible pointer type
make[1]: *** [drivers/char/tpm/tpm_stm_st19_i2c.o] Error 1

The locked ioctl was removed in commit
b19dd42faf413b4705d4adb38521e82d73fa4249



- James
-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/