linux-kernel - Re: -mm: xfs lockdep warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 04 Oct 2010 11:01:19 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Torsten Kaiser <just.for.lkml@...glemail.com>
CC:	Christoph Hellwig <hch@...radead.org>,
	Dave Chinner <david@...morbit.com>,
	Yang Ruirui <ruirui.r.yang@...to.com>,
	Andrew Morton <akpm@...ux-foundation.org>, xfs@....sgi.com,
	linux-kernel@...r.kernel.org, Alex Elder <aelder@....com>
Subject: Re: -mm: xfs lockdep warning

Hello,

On 09/25/2010 03:08 PM, Torsten Kaiser wrote:
> [adding Tejun Heo, because I'm partly blaming his workqueues]

:-) Sorry about the delay.  I was away the last week.

> After that I enabled lockdep and retried the same update: This time no
> hang, only the same lockdep report that Yang Ruirui had.
> 
> So I'm currently at a loss how I should continue from here. The XFS
> false positive drowns any other lockdep problems, but XFS had some
> hang problems with the new workqueues. (Personally I had no other hang
> with earlier 2.6.36-rcs)

If workqueue lockdep annotations are triggering spuriously, just nuke
all lockdep annotations in workqueue.c.  Currently the annotations are
the same as before and trigger even when an actual deadlock won't
happen anymore around flushes (but then again all the current users
should be operating under the same constraints as before).  I'm
looking into how to improve the lockdep annotations but in the end it
might be best to leave it as it is.  I'll try to analyze the warnings.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/