linux-kernel - Re: [RESEND] [PATCH] Input: add appleir USB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 5 Oct 2010 08:02:14 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc:	Bastien Nocera <hadess@...ess.net>,
	"linux-input" <linux-input@...r.kernel.org>,
	Jiri Kosina <jkosina@...e.cz>,
	"linux-kernel" <linux-kernel@...r.kernel.org>
Subject: Re: [RESEND] [PATCH] Input: add appleir USB driver

Am Dienstag, 5. Oktober 2010, 06:45:20 schrieb Dmitry Torokhov:
> > > +{
> > > +   struct appleir *appleir = input_get_drvdata(dev);
> > > +
> > > +   mutex_lock(&appleir_mutex);
> > > +
> > > +   if (!(appleir->flags & APPLEIR_SUSPENDED)) {
> > > +           usb_kill_urb(appleir->urb);
> > > +           del_timer_sync(&appleir->key_up_timer);
> > 
> > You can close with a key unreleased.
> 
> I think this is handled by input core. We forcibly send release events
> when device is disconnected; this takes care of surprise disconnect case.
> OTOH if input_dev->close() is called that means that there are no more
> listeners for the events so the fact that a key is still pressed is not
> interesting to anyone.

But what about the next opener? He'll get a completely spurious
key release event, as the next key is pressed.

> > > +           usb_kill_urb(appleir->urb);
> > 
> > If the system goes to sleep you'd better report a pressed key
> > as released here and kill the timer.
> 
> Input core sends "release" events upon resume so we should be OK.

I see. OK, this is covered.

	Regards
		Oliver
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/