| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 6 Oct 2010 10:24:22 +0200 From: Sascha Hauer <s.hauer@...gutronix.de> To: Dan Williams <dan.j.williams@...el.com> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org> Subject: Re: [PATCH 4/4] dmaengine: Add Freescale i.MX1/21/27 DMA driver On Tue, Oct 05, 2010 at 04:16:09PM -0700, Dan Williams wrote: >> + unsigned int channel; >> + unsigned int imxdma_channel; >> + >> + enum dma_data_direction direction; > > Why does the channel have a direction isn't that a function of the > transaction? It's also unused. > >> + enum dma_slave_buswidth word_size; >> + dma_addr_t bd_phys; > > unused? > >> + unsigned long flags; > > unused? Sorry, it seems I was a bit too fast posting it. I'll send an updated version. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists