linux-kernel - Re: [PATCH] usb: gadget: langwell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 6 Oct 2010 08:04:23 +0530
From:	Rahul Ruikar <rahul.ruikar@...il.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	David Brownell <dbrownell@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Joe Perches <joe@...ches.com>, linux-usb@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: gadget: langwell_udc: Fix error path

updated patch with following changes.
- variable name changed
- comment updated.

Please find it attached here.

- Rahul Ruikar





On 6 October 2010 00:47, Sergei Shtylyov <sshtylyov@...sta.com> wrote:
> Hello.
>
> Rahul Ruikar wrote:
>
>> Fix for following cases
>> - Call device_unregister() only when device_register() is success.
>
>   s/is success/succeeds/
>
>> - Call put_device() when device_register() fails.
>> - Call device_remove_file() only when device_create_file() is success.
>
>   s/is success/succeeds/
>
>> Signed-off-by: Rahul Ruikar <rahul.ruikar@...il.com>
>
> [...]
>
>> diff --git a/drivers/usb/gadget/langwell_udc.h
>> b/drivers/usb/gadget/langwell_udc.h
>> index 9719934..b212a70 100644
>> --- a/drivers/usb/gadget/langwell_udc.h
>> +++ b/drivers/usb/gadget/langwell_udc.h
>> @@ -199,7 +199,9 @@ struct langwell_udc {
>>                                vbus_active:1,
>>                                suspended:1,
>>                                stopped:1,
>> -                               lpm:1;  /* LPM capability */
>> +                               lpm:1,  /* LPM capability */
>> +                               reg_status:1,
>> +                               file_create:1;
>
>   I'd rather have called this 'file_created'.
>
>>        /* pci state used to access those endpoints */
>>        struct pci_dev          *pdev;
>
> WBR, Sergei
>

View attachment "0001-usb-gadget-langwell_udc-Fix-error-path.patch" of type "text/x-patch" (2188 bytes)